FreeAndNil commented on code in PR #306: URL: https://github.com/apache/logging-log4net/pull/306#discussion_r3738445027
########## src/log4net/Config/XmlConfigurator.cs: ########## @@ -140,7 +140,7 @@ private static void InternalConfigure(ILoggerRepository repository, Func<XmlElem /// </remarks> /// <seealso cref="Log4NetConfigurationSectionHandler"/> public static ICollection Configure() - => Configure(LogManager.GetRepository(Assembly.GetCallingAssembly())); + => Configure(LogManager.GetRepository(CallerAssembly.IsSupported ? Assembly.GetCallingAssembly() : CallerAssembly.Fallback)); Review Comment: Personally, I think `[DynamicallyAccessedMembers(DynamicallyAccessedMemberTypes.PublicParameterlessConstructor)]` is the bigger eyesore. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
