FreeAndNil commented on code in PR #306:
URL: https://github.com/apache/logging-log4net/pull/306#discussion_r3792702438
##########
src/log4net.Tests/Util/SystemInfoTest.cs:
##########
@@ -171,4 +173,102 @@ public void EqualsIgnoringCase_DifferentStrings_false()
[Platform(Include = "Win,Linux,MacOsX")]
public void IsAndoid()
=> Assert.That(typeof(SystemInfo).GetProperty("IsAndroid",
BindingFlags.Static | BindingFlags.NonPublic)?.GetValue(null), Is.False);
+
+ /// <summary>
+ /// <see cref="SystemInfo.GetAppSetting"/> falls back to environment
variables once the
+ /// configuration system has failed - which is what happens under Native
AOT, where
+ /// System.Configuration is trimmed away.
+ /// </summary>
+ /// <remarks>
+ /// <para>
+ /// That failure cannot be provoked on a JIT runtime, so the latch that
records it is flipped
+ /// directly, the same way <see cref="IsAndoid"/> reaches a non-public
member. The environment
+ /// must stay untouched while the configuration system still works,
otherwise a malformed
Review Comment:
Fixed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
