FreeAndNil commented on code in PR #319:
URL: https://github.com/apache/logging-log4net/pull/319#discussion_r4040955935
##########
src/log4net/Appender/RollingFileAppender.cs:
##########
@@ -556,9 +566,17 @@ protected virtual void AdjustFileBeforeAppend()
}
}
- if (_rollSize && (File is not null) &&
((CountingQuietTextWriter)QuietWriter!).Count >= MaxFileSize)
+ if (_rollSize && (File is not null)
+ && ((CountingQuietTextWriter)QuietWriter!).Count >= MaxFileSize)
Review Comment:
SetQWForFiles is sadly protected virtual. I accidentally renamed it in 3.0.4
and had the revert that quite quick, because users were getting errors with
3.0.4.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
