gdziadkiewicz commented on code in PR #319:
URL: https://github.com/apache/logging-log4net/pull/319#discussion_r4041975614
##########
src/log4net/Appender/RollingFileAppender.cs:
##########
@@ -1353,7 +1466,11 @@ protected virtual void RollOverRenameFiles(string
baseFileName)
CurrentSizeRollBackups++;
// Rename fileName to fileName.1
- RollFile(baseFileName, CombinePath(baseFileName, ".1"));
+ if (!TryRollFile(baseFileName, CombinePath(baseFileName, ".1")))
+ {
+ CurrentSizeRollBackups--;
+ RecordFailedBaseRename(baseFileName, CombinePath(baseFileName, ".1"),
wasBackupCountReverted: true);
Review Comment:
I will try to repro/prepare test for that
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
