gdziadkiewicz commented on code in PR #319:
URL: https://github.com/apache/logging-log4net/pull/319#discussion_r4061206377
##########
src/log4net/Appender/RollingFileAppender.cs:
##########
@@ -587,6 +614,12 @@ protected override void OpenFile(string fileName, bool
append)
{
fileName = GetNextOutputFileName(fileName);
+ // A rename that failed left its file where it was. Never truncate that
one, whatever
+ // AppendToFile says, or the roll destroys what it could not move.
+ append = append
+ || (_pendingRename is not null
+ && string.Equals(fileName, _pendingRename.From,
StringComparison.Ordinal));
Review Comment:
If possible, let's also address this
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
