ramanathan1504 commented on PR #4316: URL: https://github.com/apache/logging-log4j2/pull/4316#issuecomment-5764917405
@jmestwa-coder Thanks. The escaping covers both the name and the value, and the new test fails without the fix. One small thing in `DumpTag`: if an attribute's `toString()` returns null, `new StringBuilder(String.valueOf(value))` now throws an NPE where the old code printed `null`. Can `escapeHtml` take the `Object` and use `new StringBuilder().append(value)`? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
