jmestwa-coder commented on PR #4316: URL: https://github.com/apache/logging-log4j2/pull/4316#issuecomment-5796160478
@ramanathan1504 looks like the changes-requested review was submitted after 3e104a4 went up, so both suggestions were already on the branch by then: - `escapeHtml` takes `Object` and builds with `new StringBuilder().append(value)`, so a null `toString()` renders as `null` instead of throwing - the call site passes `value` directly Head matches both suggestions verbatim, `DumpTagTest` passes locally and CI is green. Could you take another look so the review can be cleared? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
