ramanathan1504 commented on code in PR #4319:
URL: https://github.com/apache/logging-log4j2/pull/4319#discussion_r4092242779
##########
log4j-core-test/src/test/java/org/apache/logging/log4j/core/appender/db/AbstractDatabaseManagerTest.java:
##########
@@ -241,6 +230,61 @@ void testBuffering04() throws Exception {
then(manager).shouldHaveNoMoreInteractions();
}
+ @Test
+ void testBufferedEventsAreDiscardedWhenCommitFails() throws Exception {
+ setUp("name", 10);
+
+ final LogEvent event1 = mock(LogEvent.class);
+ final LogEvent event2 = mock(LogEvent.class);
+
+ when(event1.toImmutable()).thenReturn(mock(LogEvent.class));
+ when(event2.toImmutable()).thenReturn(mock(LogEvent.class));
+
+ manager.startup();
+ manager.write(event1, null);
+ manager.write(event2, null);
+
+ // The first flush fails while committing the transaction, the next
one succeeds.
+ doThrow(new DbAppenderLoggingException("Failed to commit the
transaction"))
+ .doReturn(true)
+ .when(manager)
+ .commitAndClose();
+
+ assertThrows(DbAppenderLoggingException.class, manager::flush);
+
+ manager.flush();
+
+ // Events of a transaction that failed to commit must not be sent
again.
+ verify(manager, times(2)).writeInternal(any(LogEvent.class), isNull());
+ }
+
+ @Test
+ void testBufferedEventsAreDiscardedWhenConnectFails() throws Exception {
+ setUp("name", 10);
+
+ final LogEvent event1 = mock(LogEvent.class);
+ final LogEvent event2 = mock(LogEvent.class);
+
+ when(event1.toImmutable()).thenReturn(mock(LogEvent.class));
+ when(event2.toImmutable()).thenReturn(mock(LogEvent.class));
+
+ manager.startup();
+ manager.write(event1, null);
+ manager.write(event2, null);
+
+ doThrow(new DbAppenderLoggingException("Failed to connect"))
+ .doNothing()
+ .when(manager)
+ .connectAndStart();
+
+ assertThrows(DbAppenderLoggingException.class, manager::flush);
+
+ manager.flush();
+
+ // Events must not be retried after a failed connection attempt.
Review Comment:
The test name says this already. Can it go?
```suggestion
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
