ramanathan1504 commented on PR #4319: URL: https://github.com/apache/logging-log4j2/pull/4319#issuecomment-5910098351
@dajiaohuang Can you apply the five suggestions above, the four comments and the changelog description in 4318_fix_database_appender_buffer_on_failed_commit.xml? One more thing: log a warning the first time a batch is discarded, so the loss is visible. AbstractDatabaseManager already does this for a failed startup with the writeWhileNotRunningLogged flag. Then this is good to merge, and the cap you proposed is open as #4369. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
