ramanathan1504 commented on code in PR #4361: URL: https://github.com/apache/logging-log4j2/pull/4361#discussion_r4127028451
########## src/site/antora/modules/ROOT/pages/manual/appenders/message-queue.adoc: ########## @@ -508,7 +508,7 @@ Only the `java:` protocol is supported. | | It specifies the -https://docs.oracle.com/javase/8/docs/api/javax/naming/spi/InitialContextFactory.html[`InitialContextFactory`]. +https://docs.oracle.com/javase/8/docs/api/javax/naming/spi/InitialContextFactory.html[`InitialContextFactory`] Review Comment: The full stop after the link was removed. This restores the original line. ```suggestion https://docs.oracle.com/javase/8/docs/api/javax/naming/spi/InitialContextFactory.html[`InitialContextFactory`]. ``` ########## src/site/antora/modules/ROOT/pages/manual/appenders/message-queue.adoc: ########## @@ -526,7 +526,7 @@ See https://docs.oracle.com/javase/{java-target-version}/docs/api/javax/naming/C | String | | -A configuration parameter for the <<JmsAppender-attr-factoryName,`InitialContextFactory`>>. +A configuration parameter for the <<JmsAppender-attr-factoryName,`InitialContextFactory`>>. It can specify a remote JNDI provider and should only point to a trusted provider. Review Comment: Can this say "must", as in the issue? The new sentence also fits on its own line. ```suggestion A configuration parameter for the <<JmsAppender-attr-factoryName,`InitialContextFactory`>>. It can point to a remote JNDI provider, so it must only point to a trusted provider. ``` ########## src/site/antora/modules/ROOT/pages/manual/appenders/message-queue.adoc: ########## Review Comment: Illustrative, outside the hunks (`message-queue.adoc` 490 and 502, both rows): ```text Only the `java:` protocol or a name without a scheme is supported. A name without a scheme is resolved by the provider set in <<JmsAppender-attr-providerURL,`providerURL`>>. ``` ########## src/site/antora/modules/ROOT/pages/manual/appenders/message-queue.adoc: ########## Review Comment: Illustrative, outside the hunks (`message-queue.adoc` 490 and 502, both rows): ```text Only the `java:` protocol or a name without a scheme is supported. A name without a scheme is resolved by the provider set in <<JmsAppender-attr-providerURL,`providerURL`>>. ``` ########## src/site/antora/modules/ROOT/partials/manual/systemproperties/properties-jndi.adoc: ########## @@ -49,7 +49,7 @@ When `true`, a Log4j JDBC Appender can use JNDI to retrieve a https://docs.oracl | Default value | `false` |=== -When `true`, a Log4j JMS Appender can use JNDI to retrieve the necessary components using the `java:` protocol. +When `true`, a Log4j JMS Appender can use JNDI to retrieve the necessary components. The `factoryName` and `providerURL` attributes can be used to configure the JNDI provider, which may be remote. These attributes should only point to trusted providers. Review Comment: The two attribute names can link to their rows on the JMS page, so a reader lands on the details. ```suggestion When `true`, a Log4j JMS Appender can use JNDI to retrieve the necessary components. The xref:manual/appenders/message-queue.adoc#JmsAppender-attr-factoryName[`factoryName`] and xref:manual/appenders/message-queue.adoc#JmsAppender-attr-providerURL[`providerURL`] attributes configure the JNDI provider, which can be remote. These attributes must only point to trusted providers. ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
