wonook commented on a change in pull request #276: [NEMO-429] SWPP TEAM11 Code
Smell Fix
URL: https://github.com/apache/incubator-nemo/pull/276#discussion_r353292849
##########
File path:
examples/beam/src/main/java/org/apache/nemo/examples/beam/AlternatingLeastSquare.java
##########
@@ -268,8 +268,8 @@ public void processElement(final ProcessContext c) throws
Exception {
extends LoopCompositeTransform<PCollection<KV<Integer, float[]>>,
PCollection<KV<Integer, float[]>>> {
private final Integer numFeatures;
private final double lambda;
- private final PCollection<KV<Integer, KV<int[], float[]>>> parsedUserData;
- private final PCollection<KV<Integer, KV<int[], float[]>>> parsedItemData;
+ private final PCollection<KV<Integer, KV<int[], float[]>>> parsedUserData;
//NOSONAR
+ private final PCollection<KV<Integer, KV<int[], float[]>>> parsedItemData;
//NOSONAR
Review comment:
For these lines, let's declare the variables `transient`, instead of putting
`//nosonar` here. In that case, you would have to declare `private final
transient PCollection...` for both lines. Thanks!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
