wonook commented on a change in pull request #276: [NEMO-429] SWPP TEAM11 Code
Smell Fix
URL: https://github.com/apache/incubator-nemo/pull/276#discussion_r353276844
##########
File path: common/src/main/java/org/apache/nemo/common/ir/IRDAG.java
##########
@@ -710,7 +710,7 @@ public IREdge getEdgeById(final String id) {
@Override
public IREdge getEdgeBetween(final String srcVertexId,
- final String dstVertexId) throws
IllegalEdgeOperationException {
Review comment:
As far as I can check, this change has to be made on both the
`common/src/main/java/org/apache/nemo/common/dag/DAG.java` and the
`common/src/main/java/org/apache/nemo/common/dag/DAGInterface.java` files, as
mentioned
[here](https://sonarcloud.io/project/issues?fileUuids=AWkltI3qgtFwgfOLu2ET%2CAWkltI3qgtFwgfOLu2EX&id=org.apache.nemo%3Anemo-project&resolved=false&rules=squid%3ARedundantThrowsDeclarationCheck)
Could you check and confirm and make the appropriate changes there, if
applicable? Thanks! 😄
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
