wonook commented on a change in pull request #276: [NEMO-429] SWPP TEAM11 Code
Smell Fix
URL: https://github.com/apache/incubator-nemo/pull/276#discussion_r353286337
##########
File path: common/src/main/java/org/apache/nemo/common/pass/Pass.java
##########
@@ -27,7 +27,7 @@
* Abstract class for optimization passes. All passes basically extends this
class.
*/
public abstract class Pass implements Serializable {
- private Predicate<IRDAG> condition;
+ private Predicate<IRDAG> condition; //NOSONAR
Review comment:
For this, let's leave this line as-is, and remove the Serializable tag on
line 29. This makes more sense. Please remove the `implements Serializable` on
line 29, and revert the change on line 30. This will solve the issue.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
