mbien commented on code in PR #5061:
URL: https://github.com/apache/netbeans/pull/5061#discussion_r1063037518
##########
platform/openide.util/test/unit/src/org/openide/util/TaskTest.java:
##########
@@ -260,26 +304,32 @@ public void
testWaitWithTimeOutReturnsAfterTimeOutWhenTheTaskIsNotComputedAtAll
fail ("Something wrong happened the task should wait for 1000ms but it
took: " + time + "\n" + log);
}
+
+
//--------------------------------------------------------------------------
@Test
- public void
testWaitOnStrangeTaskThatStartsItsExecutionInOverridenWaitFinishedMethodLikeFolderInstancesDo
() throws Exception {
+ public void
waitOnTask_thatStartsItsExecutionWithOverridenWaitFinishedMethod()
Review Comment:
the test case methods are getting _really_ long. I personally would prefer
having waitOnTask1-x while putting the rest into the javadoc for the method.
I believe junit 5 (which we don't use) has a description annotation. This
would also make it easier one day to move the doc comment into an annotation if
someone decides to upgrade the testing lib.
##########
platform/openide.util/test/unit/src/org/openide/util/TaskTest.java:
##########
@@ -35,7 +35,8 @@
public class TaskTest {
- private final static long tenMiliseconds = 10000000; // in nanosecods
+ private final static long tenMiliseconds = 10000000; // in nanoseconds
+ private final static long fiveHundredMiliseconds = 500000000; // in
nanoseconds
Review Comment:
nitpick for future: this could use
[underscores](https://docs.oracle.com/javase/7/docs/technotes/guides/language/underscores-literals.html)
to further improve readability. But you added comments which is already great.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
