lbownik commented on code in PR #5061:
URL: https://github.com/apache/netbeans/pull/5061#discussion_r1063389250
##########
platform/openide.util/test/unit/src/org/openide/util/TaskTest.java:
##########
@@ -260,26 +304,32 @@ public void
testWaitWithTimeOutReturnsAfterTimeOutWhenTheTaskIsNotComputedAtAll
fail ("Something wrong happened the task should wait for 1000ms but it
took: " + time + "\n" + log);
}
+
+
//--------------------------------------------------------------------------
@Test
- public void
testWaitOnStrangeTaskThatStartsItsExecutionInOverridenWaitFinishedMethodLikeFolderInstancesDo
() throws Exception {
+ public void
waitOnTask_thatStartsItsExecutionWithOverridenWaitFinishedMethod()
Review Comment:
I try to follow the convention "what_behavesHow_underWhatConditions" which I
adopted from [Kevlin Henney](https://youtu.be/3frRGQGiPuc?t=2829) - it sorts
incely in IDEs class view.
yes - the test methods bacome longer but also more descriptive (though
putting some of this description ind annotation might be good).
the reliefing factor is that nobody call these methods directly :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
