mbien commented on code in PR #5061:
URL: https://github.com/apache/netbeans/pull/5061#discussion_r1063944744
##########
platform/openide.util/test/unit/src/org/openide/util/TaskTest.java:
##########
@@ -260,26 +304,32 @@ public void
testWaitWithTimeOutReturnsAfterTimeOutWhenTheTaskIsNotComputedAtAll
fail ("Something wrong happened the task should wait for 1000ms but it
took: " + time + "\n" + log);
}
+
+
//--------------------------------------------------------------------------
@Test
- public void
testWaitOnStrangeTaskThatStartsItsExecutionInOverridenWaitFinishedMethodLikeFolderInstancesDo
() throws Exception {
+ public void
waitOnTask_thatStartsItsExecutionWithOverridenWaitFinishedMethod()
Review Comment:
yes but this is simply too long - it doesn't scale. They also do appear in
test output windows etc and this makes it hard to read. I would just give up
reading after the second compound word and look at the code instead. Esp since
some of the names are longer then the test code - its just noise.
`waitOnTask` with a short description if necessary makes it more useful and
is also closer to the style already in other tests. Please try to find some
middle ground and don't use method name as a full sentence.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
