matthiasblaesing commented on PR #5609: URL: https://github.com/apache/netbeans/pull/5609#issuecomment-1484133563
So turning back to the PR itself and not the politics around it. I had some suggestions/thoughts that address my technical points and might also partially address @mbien concerns: https://github.com/matthiasblaesing/netbeans/tree/BuildNetBeansWithNbJavac The branch was rebased onto master to fix the merge conflicts. Changes: - b4eaeaa6bcad8a4df17c9cc3db9f5311f98764f9: `loadClass` is not synchronized and does not synchronize access to the caching `HashMap`. Instead of introducing synchronization, use a thread safe `ConcurrentHashMap`. - a655b626ce1ad1569953e882ec68e40826876b1e: Don't kill `-Werror`, instead only suppress the warnings created by the broken `ct.sym` files. A comment was added documenting, that this workaround has to be removed, once the next nbjavac release is there. - 34902ef592bee4b0d1bb5bea2b9e55259e0d13d9: Add information about the usecase of this approach and the limits it poses. - f6b8ece1c928d2078288a0eeb3d4de6324d7b9ad: Only run the nbjavac test job when the `Java` label is added to the PR. This is in line with other long running/additional java jobs, that should not be run everytime a change is made somewhere in the codebase @jtulach could you please have a look at this? Feel free to use the branch or cherry pick the additional commits. @mbien could you check if that addresses some of you concerns? We can discuss whether nbjavac is really a good idea, but at this point in time it is an integral part of the core of Java editing in NetBeans and I think it might help catching bugs. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected] For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
