jtulach commented on PR #5609: URL: https://github.com/apache/netbeans/pull/5609#issuecomment-1491864438
Thank you for your comments. First and foremost: This PR **doesn't change anything on the way NetBeans is built** by default. An opt-in is needed to turn the functionality on. Description of the PR has been updated to highlight that. Thanks @matthiasblaesing for your changes in https://github.com/apache/netbeans/pull/5609#issuecomment-1484133563 - I've accepted all of the ones for `CustomJavac.java` file. I haven't accepted anything in the GitHub Actions area - there are some mention of [Rust](https://github.com/matthiasblaesing/netbeans/blob/e1cdf89868d9845db7c98981bde111364ec662f8/.github/workflows/main.yml#L58) and I got confused/scared without knowing what to take and what not? Let's make it subject of further discussion. I have two approvals. @neilcsmith-net wrote: > If this change helps with testing upstream, it could go in. @matthiasblaesing helped me polish this PR greatly - see 42ed77a. @mbien wrote: > it is ok to add a few lines to the ant task if they make it easier for the nb-javac project to run CI tests I believe we are all able to accept this **opt-in support for nb-javac** compiler executed from its JARs. I am removing the "do not merge" label and I'd like to integrate my change. Once it is in, the https://github.com/JaroslavTulach/nb-javac/pull/17 will go in as well. Further improvements (CI, discovery of nb-javac, removal of `-Xlint:classfile`, etc.) to this PR are of course possible. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected] For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
