jtulach commented on code in PR #5609:
URL: https://github.com/apache/netbeans/pull/5609#discussion_r1154409704
##########
nbbuild/antsrc/org/netbeans/nbbuild/CustomJavac.java:
##########
@@ -395,16 +410,20 @@ public boolean execute() throws BuildException {
}
}
}
- if ("-Werror".equals(args[i])) {
- args[i] = "-Xlint:none";
- }
}
+ // nbjavac in version 19 contains invalid ct.sym files, which cause
+ // warnings from build. Some of the modules are compiled with
+ // -Werror and thus this breaks the build
+ // Ater the update to version 20 this should be removed.
+ String[] args2 = new String[args.length + 1];
+ args2[0] = "-Xlint:-classfile";
+ System.arraycopy(args, 0, args2, 1, args.length);
Review Comment:
Thank you @matthiasblaesing - this is certainly better than my previous
`-Xlint:none` code!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
