sid-srini opened a new pull request, #9425:
URL: https://github.com/apache/netbeans/pull/9425
- The nbexec platform launcher, used by ide launcher (netbeans) and the
harness launcher (app.sh), even on macos, should honour `JAVA_HOME` and
`PATH`-based JDKs when `jdkhome` is unspecified.
- This fix brings parity with unix (PR #8725) and windows (PR #8408) for the
nbexec launcher's behaviour on MacOS.
- Additionally, since netbeans is no longer supported on JDK 8, the
Apple-specific options targeting JDK 8 as a fallback are removed.
- Finally, the Apple `/usr/libexec/java_home` tool no longer supports a
suffix '+' in the version string to indicate a minimum supported version, and
only uses the `--version` filter as an exact match.
- Thus, the `--version` argument has been dropped.
- The current behaviour of the tool is to return the latest version jvm
available in `/Library/Java/JavaVirtualMachines/` (or similar Apple-specific
locations only) as the default.
- The `PATH` based fallback is left as the last one since the
`java_home` tool provides the correctly resolved JDK home instead of the Apple
java launcher utilities, `/usr/bin/javac` and `/usr/bin/java`, which are
expected to always be on the PATH.
---
**^Add meaningful description above**
<details open>
<summary>Click to collapse/expand PR instructions</summary>
By opening a pull request you confirm that, unless explicitly stated
otherwise, the changes -
- are all your own work, and you have the right to contribute them.
- are contributed solely under the terms and conditions of the Apache
License 2.0 (see section 5 of the license for more information).
Please make sure (eg. `git log`) that all commits have a valid name and
email address for you in the Author field.
If you're a first time contributor, see the Contributing guidelines for more
information.
If you're a committer, please label the PR before pressing "Create pull
request" so that the right test jobs can run.
### PR approval and merge checklist:
1. [ ] Was this PR [correctly
labeled](https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=240884239#PRsandYouAreviewerGuide-PRtriggeredCIJobs(conditionalCIpipeline)),
did the right tests run? When did they run?
2. [ ] Is this PR
[squashed](https://cwiki.apache.org/confluence/display/NETBEANS/git%3A+squash+and+merge)?
3. [ ] Are author name / email address correct? Are
[co-authors](https://docs.github.com/en/pull-requests/committing-changes-to-your-project/creating-and-editing-commits/creating-a-commit-with-multiple-authors#creating-co-authored-commits-on-the-command-line)
correctly listed? Do the commit messages need updates?
3. [ ] Does the PR title and description still fit after the Nth iteration?
Is the description sufficient to appear in the release notes?
If this PR targets the delivery branch: [don't
merge](https://cwiki.apache.org/confluence/display/NETBEANS/Pull+requests+for+delivery).
([full wiki
article](https://cwiki.apache.org/confluence/display/NETBEANS/PRs+and+You+-+A+reviewer+Guide))
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
