neilcsmith-net commented on PR #9425: URL: https://github.com/apache/netbeans/pull/9425#issuecomment-4615009927
Thanks, looks good to me! > Personally, I am not entirely convinced if the launcher should change the value of a well-known env var, not specific to the NetBeans platform, for subsequent usage from the IDE. For example, it may cause a mismatch in the user's expectations on their code run from the IDE vs. a terminal. This may be even more stark with the IDE distribution which contains a (private) jdkhome bundled within itself. Yes, that's fair enough - keep as a separate issue for further thought. The IDE distributions with JDK for Linux do actually set `JAVA_HOME` to the same as `jdkhome` if it's not already set. I added that because it's quite useful when using the terminal in the IDE. I just realised the macOS launcher doesn't while considering how it interacts with your change. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected] For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
