sid-srini commented on PR #9425: URL: https://github.com/apache/netbeans/pull/9425#issuecomment-4614893260
Thanks a lot @neilcsmith-net for your review and suggestions. I've incorporated the feedback on lifting the `JAVA_HOME` check outside the OS-specific block, as well as, making it take precedence over sdkman. I have not exported `JAVA_HOME` with the value set for `jdkhome` mainly so that the change may be made uniformly for windows and *nixes in a separate PR, depending on overall consensus. Personally, I am not entirely convinced if the launcher should change the value of a well-known env var, not specific to the NetBeans platform, for subsequent usage from the IDE. For example, it may cause a mismatch in the user's expectations on their code run from the IDE vs. a terminal. This may be even more stark with the IDE distribution which contains a (private) jdkhome bundled within itself. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected] For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
