[
https://issues.apache.org/jira/browse/OFBIZ-12364?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17441239#comment-17441239
]
ddev commented on OFBIZ-12364:
------------------------------
Hmm. Perhaps I should have split this into two separate issues.
The first issue would be that what the demo data puts in the description field
is not a description, it's a title. So just correcting it to a description of
of the position types of Chief Executive Officer, etc would fix that. Of
course that brings up the problem of what to put in the field that wouldn't
sound lame. For example, we could just convert them to a description by saying
things like "Doing Chief Executive Officer type stuff".
A example of a real description can be seen at:
[https://www.bls.gov/oes/current/oes111011.htm|https://www.bls.gov/oes/current/oes111011.htm)]
, but trying to use a real description like that immediately runs into this
issue: https://issues.apache.org/jira/browse/OFBIZ-12021 (I.E. that
descriptions are limited to 255 chars)
Should demo data just get hacked off at 255? If so, I could resubmit a patch
for the first issue of just correcting the demo data of the description field.
The second issue would be "It would be cool to extend the table to include the
title as well as the description"
>Please consider next time to provide your proposed change in the form of a
>pull request from your dev branch in your public facing repository. Others,
>not interested in working with patch files in a ticket, may then come out to
>collaborate more
I would need more information. I am pulling from github, but I believe that
the github version is a clone of the project. Would doing a github pull
request work? Or would I need to pull & pull request it through Jira somehow?
> Incorrect definition and usage of EmplPositionType?
> ---------------------------------------------------
>
> Key: OFBIZ-12364
> URL: https://issues.apache.org/jira/browse/OFBIZ-12364
> Project: OFBiz
> Issue Type: Improvement
> Components: humanres
> Affects Versions: Trunk
> Reporter: ddev
> Priority: Major
> Attachments: ofbiz-empl-position-type-patch.diff
>
>
> In the Data Model Resouce Book, on page 326 (or on page 306, depending on how
> you are counting pages), it shows EmplPositionType having fields "title" for
> the position title, and "description" to describe what the position is
> supposed to be about.
> However, EmplPositionType in ofbiz is missing the "title" field.
> Fixing this is a simple one line patch.
> However, additionally ofbiz seed data seems to put the title data in the
> description field, like so:
> applications/datamodel/data/seed/HumanResSeedData.xml: <EmplPositionType
> description="Chief Executive Officer" hasTable="N" emplPositionTypeId="CEO"/>
> This is a simple patch as well (patch is attached)
> But does this mean we would assume that people are putting the title in the
> description field in their local database, meaning we wouldn't patch it
> without some kind of translation system to move the description data to the
> title field. What about those people who are using the field correctly
> already?
>
>
>
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
