[ 
https://issues.apache.org/jira/browse/OFBIZ-12364?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17441315#comment-17441315
 ] 

ddev commented on OFBIZ-12364:
------------------------------

This is a bit of a tangent, so I put this in a separate second comment, but 
does anyone know why EmplPosition does not have a description field? (Note I'm 
asking about *EmplPosition* not *EmplPositionType* (which we have been talking 
about up to this point)

 

Example data:

EmplPositionType:

we create a type for a administrative assistant:

emplPositionTypeId = 100, description = "Does administrative assistant type 
things"

 

EmplPosition:

we create a position for the administrative assistant for Bob:

emplPositionId = 201, emplPositionTypeId = 100, \{dates and flags...}

we create a position for the administrative assistant for John:

emplPositionId = 202, emplPositionTypeId = 100, \{dates and flags...}

(there is no way to tell which position is for Bobs assistant and which 
position is for Johns assistant)

 

Obviously a description field can be added to EmplPosition, and some companies 
will have positions types with interchangeable positions, but I have trouble 
imagining many companies that don't have *some* non-interchangable positions.  
When I see things like that it makes me wonder if I'm misunderstanding how the 
EmplPosition table is supposed to be used.  Since how I'm understanding it, the 
need for a description field in EmplPosition would be so prevalent that I would 
expect it to be in the book.

 

 

> Incorrect definition and usage of EmplPositionType?
> ---------------------------------------------------
>
>                 Key: OFBIZ-12364
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-12364
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: humanres
>    Affects Versions: Trunk
>            Reporter: ddev
>            Priority: Major
>         Attachments: ofbiz-empl-position-type-patch.diff
>
>
> In the Data Model Resouce Book, on page 326 (or on page 306, depending on how 
> you are counting pages), it shows EmplPositionType having fields "title" for 
> the position title, and "description" to describe what the position is 
> supposed to be about.
> However, EmplPositionType in ofbiz is missing the "title" field. 
> Fixing this is a simple one line patch.
> However, additionally ofbiz seed data seems to put the title data in the 
> description field, like so:
> applications/datamodel/data/seed/HumanResSeedData.xml: <EmplPositionType 
> description="Chief Executive Officer" hasTable="N" emplPositionTypeId="CEO"/>
> This is a simple patch as well (patch is attached)
> But does this mean we would assume that people are putting the title in the 
> description field in their local database, meaning we wouldn't patch it 
> without some kind of translation system to move the description data to the 
> title field.  What about those people who are using the field correctly 
> already?
>  
>  
>  



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

Reply via email to