JacquesLeRoux commented on code in PR #517:
URL: https://github.com/apache/ofbiz-framework/pull/517#discussion_r1149451262
##########
applications/order/groovyScripts/shoppinglist/ShoppingListServices.groovy:
##########
@@ -131,39 +123,30 @@ def updateShoppingListItem() {
/**
* Remove a ShoppingListItem
- * @return
*/
-def removeShoppingListItem() {
- GenericValue shoppingList =
from("ShoppingList").where(parameters).queryOne()
- GenericValue shoppingListItem =
from("ShoppingListItem").where(parameters).queryOne()
+Map removeShoppingListItem() {
+ GenericValue shoppingList =
from('ShoppingList').where(parameters).queryOne()
+ GenericValue shoppingListItem =
from('ShoppingListItem').where(parameters).queryOne()
shoppingListItem.remove()
updateLastAdminModified(shoppingList, userLogin)
return success()
}
Review Comment:
I got that (it's very common in your changes, great), I was just speaking
about the position of its definition.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@ofbiz.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
