rrwright commented on code in PR #744:
URL: https://github.com/apache/pekko-http/pull/744#discussion_r2331434310
##########
http/src/main/resources/reference.conf:
##########
@@ -52,11 +52,20 @@ pekko.http {
# server-sent events
sse {
- # The maximum size for parsing server-sent events.
- max-event-size = 8192
+ # The maximum size for parsing received server-sent events.
+ # This value must be larger than `max-line-size`. Set to 0 to disable
limit entirely (unlimited).
+ max-event-size = 115713
Review Comment:
As noted in the PR description and in [other reviewer
comments](https://github.com/apache/pekko-http/pull/744#issuecomment-3260298481),
8k (and 4k) is extremely small for any modern use case. I believe the argument
for keeping these values small is because Pekko messages should be small (and
instead convey a link to fetch larger payloads through an outside channel if
needed), but these limits are not actually limiting Pekko messages, they are
limiting what is read out of the HTTP connection. Small limits combined with
the existing behavior of the SSE connector (swallows stream failure messages
caused by this limit being triggered) cause silent failures and lost data.
Also noted in the PR description, this is another new arbitrary value and
very reasonably argued against, and not core the changes proposed in this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
