rrwright commented on code in PR #744:
URL: https://github.com/apache/pekko-http/pull/744#discussion_r2345568840
##########
http/src/main/resources/reference.conf:
##########
@@ -52,11 +52,20 @@ pekko.http {
# server-sent events
sse {
- # The maximum size for parsing server-sent events.
- max-event-size = 8192
+ # The maximum size for parsing received server-sent events.
+ # This value must be larger than `max-line-size`. Set to 0 to disable
limit entirely (unlimited).
+ max-event-size = 115713
Review Comment:
for sure. I had used browsers as the prototypical comparison. The proposed
size, `115713`, comes from Chrome's limit on web-socket message size. Size
limits for SSE lines and messages apparently doesn't exist for browsers (at
least that I could find). I'll try to collect some other related examples from
other clients and include them here to make the case.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
