rrwright commented on code in PR #744:
URL: https://github.com/apache/pekko-http/pull/744#discussion_r2331434435
##########
http/src/main/scala/org/apache/pekko/http/javadsl/settings/ServerSentEventSettings.scala:
##########
@@ -42,9 +45,47 @@ abstract class ServerSentEventSettings private[pekko] () {
self: ServerSentEvent
*/
def emitEmptyEvents: Boolean
- // ---
+ /**
+ * How to handle messages that exceed max-line-size limit.
+ * Valid options: "fail-stream", "log-and-skip", "truncate", "dead-letter"
+ */
Review Comment:
Added. Looking through code for precedents, it looks like it may also apply
to enums, sealed traits, or other things. I'm not entirely sure where it's
required, but please advise if some were missed or others are unnecessary. (in
latest commit)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
