rrwright commented on code in PR #744: URL: https://github.com/apache/pekko-http/pull/744#discussion_r2361391016
########## http/src/main/java/org/apache/pekko/http/javadsl/settings/OversizedSseStrategy.java: ########## @@ -0,0 +1,79 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.pekko.http.javadsl.settings; + +/** + * Strategy for handling oversized SSE messages that exceed the configured max-line-size. + * + * @since 1.3.0 + */ +public enum OversizedSseStrategy { + /** + * Fail the stream with an IllegalStateException when an oversized message is encountered. This is + * the default behavior to maintain backward compatibility. + */ + FailStream, Review Comment: My thought on style choices like that is to prioritize consistency with the other code in the repo. Looks like there is some variation throughout all Pekko libraries, though consistent usage of UPPERCASE in pekko streams (like the `AsPublisher` example you linked to). But in this pekko-http repo, a quick check looks like CamelCase is used everywhere in the production code (e.g.: `Coder`, `SameSite`), and the UPPERCASE notation is used in a test (e.g. `MyRole`). That makes me think it fits best in the local scope of this repository to keep it as CamelCase. But no strong opinion here. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
