mdedetrich commented on code in PR #2409:
URL: https://github.com/apache/pekko/pull/2409#discussion_r2469483179
##########
project/Dependencies.scala:
##########
@@ -351,7 +351,8 @@ object Dependencies {
// pekko stream
- lazy val stream = l ++= Seq[sbt.ModuleID](reactiveStreams,
TestDependencies.scalatest)
+ lazy val stream =
+ l ++= Seq[sbt.ModuleID](reactiveStreams, "com.github.luben" % "zstd-jni" %
"1.5.7-6", TestDependencies.scalatest)
Review Comment:
Making it optional/provided is not going to give as any benefits as we would
need to force users to redundantly provide a zstd implementation (which is
going to be `"com.github.luben" % "zstd-jni" % "1.5.7-6"` anyways).
To do this properly, we would need to make a zstd agnostic API and then
provided concrete implementations in a different artifact and considering that
there is only a single candidate for a proper implementation (as discussed at
https://github.com/apache/pekko/issues/2404#issuecomment-3450106736) we
wouldn't gain any benefit out of it.
Hence zstd is being treated the same way as lz4Java is (for the same
reasons), where we have a [simple direct
dependency](https://github.com/apache/pekko/blob/1b54c97914e91af287af8681875bee317e968c58/project/Dependencies.scala#L106)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
