mdedetrich commented on code in PR #2409:
URL: https://github.com/apache/pekko/pull/2409#discussion_r2469507179
##########
project/Dependencies.scala:
##########
@@ -351,7 +351,8 @@ object Dependencies {
// pekko stream
- lazy val stream = l ++= Seq[sbt.ModuleID](reactiveStreams,
TestDependencies.scalatest)
+ lazy val stream =
+ l ++= Seq[sbt.ModuleID](reactiveStreams, "com.github.luben" % "zstd-jni" %
"1.5.7-6", TestDependencies.scalatest)
Review Comment:
On another note there is a silver lining here, since zstd-jni uses JNI, the
C shared objects which are platform dependent are contained within the jar
artifact. The `"com.github.luben" % "zstd-jni" % "1.5.7-6"` artifact contains
the C shared objects for **all** of the platforms (see
https://github.com/luben/zstd-jni?tab=readme-ov-file#binary-releases for which
ones are supported) but there are platform dependent jars if you only care
about a single platform.
This does give some credence to using provided, as a user can provide their
own zstd-jni artifact however there are still some things to note here. If we
end up using `provided` then we force all pekko end users to add a zstd-jni
artifact to their dependencies (with `"com.github.luben" % "zstd-jni" %
"1.5.7-6"` being the documented default) as its not going to be including by in
the dependency resolution.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
