pjfanning commented on code in PR #2409:
URL: https://github.com/apache/pekko/pull/2409#discussion_r2469505671
##########
project/Dependencies.scala:
##########
@@ -351,7 +351,8 @@ object Dependencies {
// pekko stream
- lazy val stream = l ++= Seq[sbt.ModuleID](reactiveStreams,
TestDependencies.scalatest)
+ lazy val stream =
+ l ++= Seq[sbt.ModuleID](reactiveStreams, "com.github.luben" % "zstd-jni" %
"1.5.7-6", TestDependencies.scalatest)
Review Comment:
How about having a separate pekko-streams-ztsd or pekko-streams-compression
so that pekko-streams core lib doesn't need this dependency? ZIO have done
something similar where a small number of compression operators are in
zio-streams but others have their own libs, eg zio-streams-compress-zstd.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
