mdedetrich commented on code in PR #2486:
URL: https://github.com/apache/pekko/pull/2486#discussion_r2522039310
##########
actor-typed/src/main/scala/org/apache/pekko/actor/typed/internal/adapter/ActorSystemAdapter.scala:
##########
@@ -122,6 +122,8 @@ import org.slf4j.{ Logger, LoggerFactory }
override lazy val getWhenTerminated: CompletionStage[pekko.Done] =
whenTerminated.asJava
+ override def close(): Unit = system.close()
Review Comment:
Same as https://github.com/apache/pekko/pull/2486#discussion_r2521369096,
this is the implementation and end users won't see it (they will see the
abstract method)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
