mdedetrich commented on code in PR #2486:
URL: https://github.com/apache/pekko/pull/2486#discussion_r2522036155
##########
actor/src/main/scala/org/apache/pekko/actor/ActorSystem.scala:
##########
@@ -1080,6 +1100,14 @@ private[pekko] class ActorSystemImpl(
whenTerminated
}
+ override def close(): Unit = {
Review Comment:
This is the implementation, the parent which defines the abstract method
(`ActorSystem`) has `@throws(classOf[TimeoutException])` which is what matters
for users, I think thats enough?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
