mdedetrich commented on PR #2486: URL: https://github.com/apache/pekko/pull/2486#issuecomment-3526480836
I have just updated the PR to actually add tests to make sure the `AutoCloseable` works as expected. There is a Java test that uses try-with-resources and there is a Scala test using `scala.util.Using` (which automatically uses `AutoCloseable`). One note is that when I cherry pick this into Pekko 1.3.x, the `scala.util.Using` tests will only work for Scala 2.13/Scala 3 so I will need to modify the tests there. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
