mdedetrich commented on PR #2409:
URL: https://github.com/apache/pekko/pull/2409#issuecomment-3596472004
@raboof So I tried to get my fancy buffering implementation done, but I am
coming across a very weird issue/problem where even if I change the current
implementation to something like this
```scala
override def compressAndFlush(input: ByteString): ByteString =
ByteString.fromArrayUnsafe(Zstd.compress(input.toArrayUnsafe))
```
The tests start failing because `onUpstreamFinish` never ends up being
executed.
So I think we should opt for the simple option for now, which is going to be
the current implementation but avoid creating a direct byte buffer on each
incoming element (instead using a pool), doing the changes now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
