raboof commented on code in PR #2409: URL: https://github.com/apache/pekko/pull/2409#discussion_r2577097461
########## actor/src/main/java/org/apache/pekko/io/ByteBufferCleaner.java: ########## @@ -36,7 +37,8 @@ * * <p>See <a href=https://bugs.openjdk.java.net/browse/JDK-4724038>JDK-4724038</a> */ -final class ByteBufferCleaner { +@InternalStableApi Review Comment: OK. I'm not super fond of committing ourselves to `@InternalStableApi` "just in case" without a specific plan on where to use it. Also we should seriously consider using the implementation from `commons-io` - definitely in satellite projects, but also here. The use of `sun.misc.Unsafe` is icky as well. I'm OK with this not blocking the merge though. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
