LegendPei commented on code in PR #7760: URL: https://github.com/apache/incubator-seata/pull/7760#discussion_r2488470707
########## common/src/main/java/org/apache/seata/common/json/JsonUtil.java: ########## @@ -0,0 +1,95 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.seata.common.json; + +import org.apache.seata.common.exception.JsonParseException; + +import java.lang.reflect.Type; + +/** + * Unified JSON utility class + */ +public final class JsonUtil { + + private final JsonSerializer serializer; + + /** + * Create a JsonUtil instance with the specified JsonSerializer implementation + * + * @param serializer the JsonSerializer implementation to use + * @throws IllegalArgumentException if serializer is null + */ + public JsonUtil(JsonSerializer serializer) { Review Comment: I'm sorry, but I don't quite understand why this modification is necessary. Isn't it possible to use different JSON parsers (fastjson or jackson) in different modules based on their specific requirements? Why not keep JsonUtil as an instantiable class, allowing each module to create its own instance using the appropriate JsonSerializer implementation?Or am I misunderstanding the intention of this unified serializer? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
