YvCeung commented on code in PR #7760: URL: https://github.com/apache/incubator-seata/pull/7760#discussion_r2488507168
########## common/src/main/java/org/apache/seata/common/json/JsonUtil.java: ########## @@ -0,0 +1,95 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.seata.common.json; + +import org.apache.seata.common.exception.JsonParseException; + +import java.lang.reflect.Type; + +/** + * Unified JSON utility class + */ +public final class JsonUtil { + + private final JsonSerializer serializer; + + /** + * Create a JsonUtil instance with the specified JsonSerializer implementation + * + * @param serializer the JsonSerializer implementation to use + * @throws IllegalArgumentException if serializer is null + */ + public JsonUtil(JsonSerializer serializer) { Review Comment: `JsonUtil` 内部确实维护了单例的 JsonSerializer， 但 `JsonUtil` 本身却是可以多次 new 的。 所以从设计角度看，它并不比直接通过工厂类 `JsonSerializerFactory.getSerializer(xxx)` 获得实例更简洁。 与其让大家都 new 一个“工具类”，不如直接让业务层通过工厂方法获取单例实例。❤ JsonUtil internally maintains a singleton JsonSerializer, but JsonUtil itself can still be instantiated multiple times. From a design perspective, this makes it no simpler than directly obtaining an instance via JsonSerializerFactory.getSerializer(). Instead of having everyone create new instances of this utility class, it would be cleaner and more aligned with the idea of a unified serialization entry point to let the business layer directly acquire the singleton instance through the factory method. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
