baiyangzhuhong commented on PR #2462: URL: https://github.com/apache/shardingsphere-elasticjob/pull/2462#issuecomment-2530462848
> Any updates? Thanks for your advice. I follow the points what you suggested, now all code formatting validation are passed as running: ```shell ./mvnw spotless:apply -Pcheck -T1C ./mvnw checkstyle:check -Pcheck -T1C ``` The new codes are pushed, please review. But I a little confused about that the checkstyle which caused the fields of `AbstractJobFacade` are all changed to 'private' access ability, otherwise it would fail on checkstyle testing. This is betrayed of the original intent of `AbstractJobFacade` which is a parent abstract class. Seems like it doesn't make sense and a little weired. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
