linghengqian commented on code in PR #2462:
URL:
https://github.com/apache/shardingsphere-elasticjob/pull/2462#discussion_r1877940952
##########
kernel/src/main/java/org/apache/shardingsphere/elasticjob/kernel/internal/schedule/JobScheduler.java:
##########
@@ -94,7 +104,15 @@ public JobScheduler(final CoordinatorRegistryCenter
regCenter, final String elas
Collection<ElasticJobListener> jobListeners =
getElasticJobListeners(this.jobConfig);
setUpFacade = new SetUpFacade(regCenter, this.jobConfig.getJobName(),
jobListeners);
schedulerFacade = new SchedulerFacade(regCenter,
this.jobConfig.getJobName());
- jobFacade = new JobFacade(regCenter, this.jobConfig.getJobName(),
jobListeners, findTracingConfiguration().orElse(null));
+
+ // the single sharding scenario and specified SINGLE_SHARDING_BALANCE
strategy
Review Comment:
Please move the comment to the method signature, or remove the comment. If
you put the comment inside the method body, the compiled JavaDoc may not see it.
##########
kernel/src/main/java/org/apache/shardingsphere/elasticjob/kernel/internal/schedule/JobScheduler.java:
##########
@@ -80,7 +82,15 @@ public JobScheduler(final CoordinatorRegistryCenter
regCenter, final ElasticJob
Collection<ElasticJobListener> jobListeners =
getElasticJobListeners(this.jobConfig);
setUpFacade = new SetUpFacade(regCenter, this.jobConfig.getJobName(),
jobListeners);
schedulerFacade = new SchedulerFacade(regCenter,
this.jobConfig.getJobName());
- jobFacade = new JobFacade(regCenter, this.jobConfig.getJobName(),
jobListeners, findTracingConfiguration().orElse(null));
+
+ // the single sharding scenario and specified SINGLE_SHARDING_BALANCE
strategy
Review Comment:
Please move the comment to the method signature, or remove the comment. If
you put the comment inside the method body, the compiled JavaDoc may not see it.
##########
kernel/src/main/java/org/apache/shardingsphere/elasticjob/kernel/internal/sharding/strategy/type/SingleShardingBalanceJobShardingStrategy.java:
##########
@@ -0,0 +1,64 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package
org.apache.shardingsphere.elasticjob.kernel.internal.sharding.strategy.type;
+
+import java.util.ArrayList;
+import java.util.List;
+import java.util.Map;
+
+import
org.apache.shardingsphere.elasticjob.kernel.internal.sharding.JobInstance;
+import
org.apache.shardingsphere.elasticjob.kernel.internal.sharding.strategy.JobShardingStrategy;
+
+/**
+ * Single sharding Balance strategy, referenced of ROUND_ROBIN strategy.
+ * <pre>
+ * it resolves the problem which ROUND_ROBIN is stick with the certain one job
instance
+ * for the hashcode of job name is a constant value. while with
SINGLE_SHARDING_BALANCE, it allows
+ * the job running on all the job instances each one by one, just like loop
the job instances.
+ *
+ * this is the real round robin balance job running in the job instance
dimension.
+ * </pre>
+ *
+ * @author hongzhu
+ * @version V1.0
+ * @since 2024-12-03 19:19
Review Comment:
Please remove this personal information unless you are referencing
third-party code that you do not own. If you are referencing third-party code,
please make sure that the third-party has consented to your contribution of
that code to the ASF.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
