baiyangzhuhong commented on PR #2462: URL: https://github.com/apache/shardingsphere-elasticjob/pull/2462#issuecomment-2531285878
> > > But I a little confused about that the checkstyle which caused the fields of AbstractJobFacade are all changed to 'private' access ability, otherwise it would fail on checkstyle testing. This is betrayed of the original intent of AbstractJobFacade which is a parent abstract class. Seems like it doesn't make sense and a little weired. > > > > > > > > * Do you mean you want to use private properties in the interface class? Can you explain why you want to do that? Interfaces should really only have public properties. > > No. I am not meaning use private properties in the Interface. What I am saying is there was checkstyle problems in the `AbstractJobFacade` class using 'protected' properties in my first commit codes, you know, this class is abstract class. I want the child class of `AbstractJobFacade` to extend the 'protected' properties. However, I have changed the codes to fix the checkstyle problems. > > Never mind about that now, the current codes are still works fine. > > > * CI is a bit shaky and I'm helping with retries. Just for clarification, I looked back of the checkstyle problems for first commit in the github thread, here is the original information,  you can reference the detail information from this address: https://github.com/apache/shardingsphere-elasticjob/pull/2462/checks?check_run_id=34090530003 thanks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
