linghengqian commented on code in PR #34335:
URL: https://github.com/apache/shardingsphere/pull/34335#discussion_r1912879440
##########
infra/database/type/firebird/src/test/java/org/apache/shardingsphere/infra/database/firebird/connector/FirebirdConnectionPropertiesParserTest.java:
##########
@@ -54,14 +56,29 @@ void assertNewConstructor(final String name, final String
url, final String host
@Test
void assertNewConstructorFailure() {
- assertThrows(UnrecognizedDatabaseURLException.class, () ->
parser.parse("jdbc:firebirdsql:xxxxxxxx", null, null));
+ assertDoesNotThrow(() -> parser.parse("jdbc:firebirdsql:xxxxxxxx",
null, null));
+ assertThrows(SQLNonTransientConnectionException.class, () ->
parser.parse("jdbc:firebirdsql://localhost:c:/data/db/test.fdb", null, null));
Review Comment:
- - According to some verification in
https://github.com/FirebirdSQL/jaybird/blob/v6.0.0/src/test/org/firebirdsql/jdbc/FBDriverTest.java
, it seems that the exception should not be thrown although a jdbcUrl like
`jdbc:firebirdsql:xxxxxxxx` does not make sense.
- What do you think? @TedCraft
##########
infra/database/type/firebird/src/test/java/org/apache/shardingsphere/infra/database/firebird/connector/FirebirdConnectionPropertiesParserTest.java:
##########
@@ -54,14 +56,29 @@ void assertNewConstructor(final String name, final String
url, final String host
@Test
void assertNewConstructorFailure() {
- assertThrows(UnrecognizedDatabaseURLException.class, () ->
parser.parse("jdbc:firebirdsql:xxxxxxxx", null, null));
+ assertDoesNotThrow(() -> parser.parse("jdbc:firebirdsql:xxxxxxxx",
null, null));
+ assertThrows(SQLNonTransientConnectionException.class, () ->
parser.parse("jdbc:firebirdsql://localhost:c:/data/db/test.fdb", null, null));
Review Comment:
- According to some verification in
https://github.com/FirebirdSQL/jaybird/blob/v6.0.0/src/test/org/firebirdsql/jdbc/FBDriverTest.java
, it seems that the exception should not be thrown although a jdbcUrl like
`jdbc:firebirdsql:xxxxxxxx` does not make sense.
- What do you think? @TedCraft
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
