TedCraft commented on code in PR #34335:
URL: https://github.com/apache/shardingsphere/pull/34335#discussion_r1913270283
##########
infra/database/type/firebird/src/test/java/org/apache/shardingsphere/infra/database/firebird/connector/FirebirdConnectionPropertiesParserTest.java:
##########
@@ -54,14 +56,29 @@ void assertNewConstructor(final String name, final String
url, final String host
@Test
void assertNewConstructorFailure() {
- assertThrows(UnrecognizedDatabaseURLException.class, () ->
parser.parse("jdbc:firebirdsql:xxxxxxxx", null, null));
+ assertDoesNotThrow(() -> parser.parse("jdbc:firebirdsql:xxxxxxxx",
null, null));
+ assertThrows(SQLNonTransientConnectionException.class, () ->
parser.parse("jdbc:firebirdsql://localhost:c:/data/db/test.fdb", null, null));
Review Comment:
According to the manual
(https://github.com/apache/shardingsphere/pull/34335#discussion_r1912879440)
the jdbcUrl format jdbc:firebirdsql:xxxxxxxxxxxx kinda makes sense, since it
uses the legacy url format used in firebird. In this case, we just specify the
database alias (or path) and the host and port are used by default
(localhost:3050). But even though this url type is supported, according to the
same manual, it is recommended to use the new url format.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
