linghengqian commented on code in PR #34335:
URL: https://github.com/apache/shardingsphere/pull/34335#discussion_r1913407161
##########
infra/database/type/firebird/src/test/java/org/apache/shardingsphere/infra/database/firebird/connector/FirebirdConnectionPropertiesParserTest.java:
##########
@@ -54,14 +56,29 @@ void assertNewConstructor(final String name, final String
url, final String host
@Test
void assertNewConstructorFailure() {
- assertThrows(UnrecognizedDatabaseURLException.class, () ->
parser.parse("jdbc:firebirdsql:xxxxxxxx", null, null));
+ assertDoesNotThrow(() -> parser.parse("jdbc:firebirdsql:xxxxxxxx",
null, null));
+ assertThrows(SQLNonTransientConnectionException.class, () ->
parser.parse("jdbc:firebirdsql://localhost:c:/data/db/test.fdb", null, null));
Review Comment:
- My understanding is that I should respect the performance of the Firebird
JDBC Driver's classes.
- There seems to be only the LGPL LICENSE for the Firebird JDBC Driver, so I
would assume that everyone who uses both shardingsphere and the Firebird JDBC
Driver would be affected by the LGPL. Maven's `optional` property is enough to
comply with the ASF's requirements when distributing. I think there is no
problem with PR at the moment.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
