gzlicanyi commented on code in PR #689:
URL: https://github.com/apache/skywalking-java/pull/689#discussion_r1601125642
##########
apm-sniffer/apm-agent-core/src/main/java/org/apache/skywalking/apm/agent/core/context/IgnoredTracerContext.java:
##########
@@ -34,14 +34,21 @@ public class IgnoredTracerContext implements
AbstractTracerContext {
private static final NoopSpan NOOP_SPAN = new NoopSpan();
private static final String IGNORE_TRACE = "Ignored_Trace";
+ private LinkedList<AbstractSpan> activeSpanStack;
Review Comment:
Do you prefer replacing the span's context with IgnoredTracerContext for old
spans with old [context
references](https://github.com/apache/skywalking-java/blob/4dfc1e85b56e75a1bf2bae11d34d8c0fe234bed0/apm-sniffer/apm-agent-core/src/main/java/org/apache/skywalking/apm/agent/core/context/trace/AbstractTracingSpan.java#L68),
or would you rather ignore any operations involving context within the span?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
