wu-sheng commented on code in PR #689: URL: https://github.com/apache/skywalking-java/pull/689#discussion_r1602736268
########## apm-sniffer/apm-agent-core/src/main/java/org/apache/skywalking/apm/agent/core/context/ContextManager.java: ########## @@ -163,7 +163,12 @@ public static void continued(ContextSnapshot snapshot) { throw new IllegalArgumentException("ContextSnapshot can't be null."); } if (!snapshot.isFromCurrent()) { - get().continued(snapshot); + if (snapshot.isValid()) { Review Comment: ```suggestion // Invalid snapshot is only created by {@link IgnoredTracerContext#capture()}. // When the snapshot is not valid, need to force ignoring the current tracing context. if (snapshot.isValid()) { ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org