weixiang1862 commented on PR #13611: URL: https://github.com/apache/skywalking/pull/13611#issuecomment-3644724842
> I am not following. The `#shutdown` was just to make sure that the thread is stopped. Nothing else. What is the purpose of the new close? `DataCarrier` driven by `BulkConsumePool` is used in aggregate and persistent workers in skywalking. Let's imagine this scenario: when a user modifies `MAL` and wants the changes to take effect immediately through hot reload, the corresponding aggregate worker and persistent worker need to be rebuilt. In this process, one step is shutting down the current worker's datacarrier without affecting the datacarriers of other workers that are still running. Consider about this, I think this changes make more sense. But if it broken something, I will close this pr. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
