wu-sheng commented on code in PR #13611:
URL: https://github.com/apache/skywalking/pull/13611#discussion_r2617140744
##########
oap-server/server-library/library-datacarrier-queue/src/main/java/org/apache/skywalking/oap/server/library/datacarrier/consumer/MultipleChannelsConsumer.java:
##########
@@ -133,6 +133,28 @@ void shutdown() {
running = false;
}
+ void close(Channels channels) {
Review Comment:
If you are going to use this in a hot-update case, I have a concern whether
this is thread safe. Because the reloading could happen in any time.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
