wu-sheng commented on code in PR #13611:
URL: https://github.com/apache/skywalking/pull/13611#discussion_r2618140680
##########
oap-server/server-library/library-datacarrier-queue/src/main/java/org/apache/skywalking/oap/server/library/datacarrier/consumer/MultipleChannelsConsumer.java:
##########
@@ -133,6 +133,28 @@ void shutdown() {
running = false;
}
+ void close(Channels channels) {
Review Comment:
Within `#addNewTarget`, for oap case, it is in the booting stage only. But
here, you are really in the runtime.
As we don't have hot-reload in the upstream, we can't verify the result.
Also, as it is allocating the channels to other consumers(in your case),
this is meaningless in upstream case, because we only call this in the shutting
down process.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
